Skip to content

[NEW] timesheets: billing rate leaderboad #13921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 18.0
Choose a base branch
from

Conversation

zulu-odoo
Copy link
Contributor

task-id: 4882126

@robodoo
Copy link
Collaborator

robodoo commented Jul 3, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team July 3, 2025 08:22
@zulu-odoo zulu-odoo force-pushed the 18.0-timesheets-rates-zulu branch from 8d75a8d to b01afc2 Compare July 3, 2025 08:41
@zulu-odoo zulu-odoo requested review from a team and removed request for a team July 3, 2025 08:41
@zulu-odoo zulu-odoo force-pushed the 18.0-timesheets-rates-zulu branch from b01afc2 to 4734f22 Compare July 4, 2025 07:49
@zulu-odoo zulu-odoo force-pushed the 18.0-timesheets-rates-zulu branch from 4734f22 to 3e84da4 Compare July 4, 2025 12:39
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work @zulu-odoo! I added a few comments and suggestions 🙂. Also:

  • Could you please change the PR title and commit message to change [NEW] into [ADD]?
  • Don't forget the app name in your anchor names (timesheets/billing_rates/xxx)
  • Could we use this opportunity (i.e., PR) to get rid of the empty "Overview" toc tree?
image

Thank you!

Configuration
-------------

To enable billing rate indicators, navigate to :menuselection:`Timesheets --> Configuration --> Settings`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line goes over the 100th character-limit?

activating a **billing rate leaderboard** in order to motivate employees and enhance workplace
transparency.

To enable the billing rate leaderboard, navigate to :menuselection:`Timesheets --> Configuration --> Settings`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line also goes over the 100th character-limit? 🙈

-------------

To enable billing rate indicators, navigate to :menuselection:`Timesheets --> Configuration --> Settings`,
then enable :guilabel:`Billing Rate Indicators`, and press :guilabel:`Save`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
then enable :guilabel:`Billing Rate Indicators`, and press :guilabel:`Save`.
then enable :guilabel:`Billing Rate Indicators`, and click :guilabel:`Save`.

(not wrong but you used "click" elsewhere in the doc and we usually assume people are doing this from a computer so for consistency 😉 )

Comment on lines +23 to +24
A new item, :guilabel:`Billing Time Targets` is then added in the :guilabel:`Configuration` menu. To
set up the targets, click :guilabel:`Billing Time Targets`, then encode the :guilabel:`Monthly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We don't usually mention that menu items are "added" and instead focus on actionable steps (e.g., To configure xxx, go to yy --> zz --> aa, enable blabla, etc.)
  • This is only true from 18.2; in 18.0, you need to click the internal link under the setting
Suggested change
A new item, :guilabel:`Billing Time Targets` is then added in the :guilabel:`Configuration` menu. To
set up the targets, click :guilabel:`Billing Time Targets`, then encode the :guilabel:`Monthly
To set up the targets, click :guilabel:`Set employee billing time targets`, then encode the :guilabel:`Monthly

in 18.2, I'd add the menu as an alternative:

Suggested change
A new item, :guilabel:`Billing Time Targets` is then added in the :guilabel:`Configuration` menu. To
set up the targets, click :guilabel:`Billing Time Targets`, then encode the :guilabel:`Monthly
To set up the targets, click :guilabel:`Set employee billing time targets` or go to :menuselection:`Timesheets --> Configuration --> Billing Time Targets`, then encode the :guilabel:`Monthly

Comment on lines +25 to +26
Billing Time Target` in hours or days, depending on the **Encoding Method** selected in the
**Timesheets** app configuration.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Billing Time Target` in hours or days, depending on the **Encoding Method** selected in the
**Timesheets** app configuration.
Billing Time Target` in hours or days, depending on the :guilabel:`Encoding Method` selected in the
**Timesheets** :guilabel:`Settings`.
  • since we are referring to that field
  • I feel like settings is more precise and makes it clear what we are referring to exactly

Comment on lines +29 to +30
Once the :guilabel:`billing rate indicators` have been enabled in **Timesheets** app
configuration, you can also navigate to the **Employees** app, access the employee form that you
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Once the :guilabel:`billing rate indicators` have been enabled in **Timesheets** app
configuration, you can also navigate to the **Employees** app, access the employee form that you
Once the :guilabel:`Billing Rate Indicators` have been enabled,, you can also navigate to the **Employees** app, access the employee form that you
  • guilabel = we match the UI's capitalization (unless it's all caps); you could also remove the guilabel here if you want since we can also argue we are referring to the general concept of billing rate indicators
  • since we just explained the configuration, I feel like we don't need to repeat it here in detail

---------------------------------

Once enabled, the billing rate indicators are displayed in the upper right corner of the
:guilabel:`My Timesheets` in Kanban, grid, and list views for all users. The monthly amount of time
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like a word is missing after "My timesheets" but I'm not sure what would work here. Any ideas?

Configuration
-------------

After the **monthly billing time targets** have been enabled, Odoo offers the possibility of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd add a ref here instead

Suggested change
After the **monthly billing time targets** have been enabled, Odoo offers the possibility of
After the :ref:`monthly billing time targets <timesheets/billing_rates/targets>` have been enabled, Odoo offers the possibility of

Comment on lines +71 to +72
It also shows the amount of the time logged by the signed in user in the format: logged billable
time / billable time target, as well as the total time logged.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
It also shows the amount of the time logged by the signed in user in the format: logged billable
time / billable time target, as well as the total time logged.
It also shows the amount of time logged by the signed-in user in the format: logged billable
time / billable time target, as well as the total time logged.

Comment on lines +90 to +91
To create or edit existing tips, navigate to :menuselection:`Timesheets --> Configuration --> Tips`.
To create a new tip, click :guilabel:`New`, and to edit the existing one, double-click on its text.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like maybe we could group these two sentences (it would also avoid repetitions):

Suggested change
To create or edit existing tips, navigate to :menuselection:`Timesheets --> Configuration --> Tips`.
To create a new tip, click :guilabel:`New`, and to edit the existing one, double-click on its text.
To create or edit existing tips, navigate to :menuselection:`Timesheets --> Configuration --> Tips`, then click :guilabel:`New` or double-click a tip's text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants