-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[NEW] timesheets: billing rate leaderboad #13921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
Conversation
8d75a8d
to
b01afc2
Compare
b01afc2
to
4734f22
Compare
4734f22
to
3e84da4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work @zulu-odoo! I added a few comments and suggestions 🙂. Also:
- Could you please change the PR title and commit message to change [NEW] into [ADD]?
- Don't forget the app name in your anchor names (timesheets/billing_rates/xxx)
- Could we use this opportunity (i.e., PR) to get rid of the empty "Overview" toc tree?

Thank you!
Configuration | ||
------------- | ||
|
||
To enable billing rate indicators, navigate to :menuselection:`Timesheets --> Configuration --> Settings`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this line goes over the 100th character-limit?
activating a **billing rate leaderboard** in order to motivate employees and enhance workplace | ||
transparency. | ||
|
||
To enable the billing rate leaderboard, navigate to :menuselection:`Timesheets --> Configuration --> Settings`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this line also goes over the 100th character-limit? 🙈
------------- | ||
|
||
To enable billing rate indicators, navigate to :menuselection:`Timesheets --> Configuration --> Settings`, | ||
then enable :guilabel:`Billing Rate Indicators`, and press :guilabel:`Save`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then enable :guilabel:`Billing Rate Indicators`, and press :guilabel:`Save`. | |
then enable :guilabel:`Billing Rate Indicators`, and click :guilabel:`Save`. |
(not wrong but you used "click" elsewhere in the doc and we usually assume people are doing this from a computer so for consistency 😉 )
A new item, :guilabel:`Billing Time Targets` is then added in the :guilabel:`Configuration` menu. To | ||
set up the targets, click :guilabel:`Billing Time Targets`, then encode the :guilabel:`Monthly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- We don't usually mention that menu items are "added" and instead focus on actionable steps (e.g., To configure xxx, go to yy --> zz --> aa, enable blabla, etc.)
- This is only true from 18.2; in 18.0, you need to click the internal link under the setting
A new item, :guilabel:`Billing Time Targets` is then added in the :guilabel:`Configuration` menu. To | |
set up the targets, click :guilabel:`Billing Time Targets`, then encode the :guilabel:`Monthly | |
To set up the targets, click :guilabel:`Set employee billing time targets`, then encode the :guilabel:`Monthly |
in 18.2, I'd add the menu as an alternative:
A new item, :guilabel:`Billing Time Targets` is then added in the :guilabel:`Configuration` menu. To | |
set up the targets, click :guilabel:`Billing Time Targets`, then encode the :guilabel:`Monthly | |
To set up the targets, click :guilabel:`Set employee billing time targets` or go to :menuselection:`Timesheets --> Configuration --> Billing Time Targets`, then encode the :guilabel:`Monthly |
Billing Time Target` in hours or days, depending on the **Encoding Method** selected in the | ||
**Timesheets** app configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Billing Time Target` in hours or days, depending on the **Encoding Method** selected in the | |
**Timesheets** app configuration. | |
Billing Time Target` in hours or days, depending on the :guilabel:`Encoding Method` selected in the | |
**Timesheets** :guilabel:`Settings`. |
- since we are referring to that field
- I feel like settings is more precise and makes it clear what we are referring to exactly
Once the :guilabel:`billing rate indicators` have been enabled in **Timesheets** app | ||
configuration, you can also navigate to the **Employees** app, access the employee form that you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the :guilabel:`billing rate indicators` have been enabled in **Timesheets** app | |
configuration, you can also navigate to the **Employees** app, access the employee form that you | |
Once the :guilabel:`Billing Rate Indicators` have been enabled,, you can also navigate to the **Employees** app, access the employee form that you |
- guilabel = we match the UI's capitalization (unless it's all caps); you could also remove the guilabel here if you want since we can also argue we are referring to the general concept of billing rate indicators
- since we just explained the configuration, I feel like we don't need to repeat it here in detail
--------------------------------- | ||
|
||
Once enabled, the billing rate indicators are displayed in the upper right corner of the | ||
:guilabel:`My Timesheets` in Kanban, grid, and list views for all users. The monthly amount of time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like a word is missing after "My timesheets" but I'm not sure what would work here. Any ideas?
Configuration | ||
------------- | ||
|
||
After the **monthly billing time targets** have been enabled, Odoo offers the possibility of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd add a ref here instead
After the **monthly billing time targets** have been enabled, Odoo offers the possibility of | |
After the :ref:`monthly billing time targets <timesheets/billing_rates/targets>` have been enabled, Odoo offers the possibility of |
It also shows the amount of the time logged by the signed in user in the format: logged billable | ||
time / billable time target, as well as the total time logged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also shows the amount of the time logged by the signed in user in the format: logged billable | |
time / billable time target, as well as the total time logged. | |
It also shows the amount of time logged by the signed-in user in the format: logged billable | |
time / billable time target, as well as the total time logged. |
To create or edit existing tips, navigate to :menuselection:`Timesheets --> Configuration --> Tips`. | ||
To create a new tip, click :guilabel:`New`, and to edit the existing one, double-click on its text. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like maybe we could group these two sentences (it would also avoid repetitions):
To create or edit existing tips, navigate to :menuselection:`Timesheets --> Configuration --> Tips`. | |
To create a new tip, click :guilabel:`New`, and to edit the existing one, double-click on its text. | |
To create or edit existing tips, navigate to :menuselection:`Timesheets --> Configuration --> Tips`, then click :guilabel:`New` or double-click a tip's text. |
task-id: 4882126